OCPBUGS-43745: Add support for IdleCloseTerminationPolicy #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frobware
changed the title
frobware
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@frobware: This pull request references Jira Issue OCPBUGS-43745, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold Many commits should never merge. |
openshift-ci
bot
added
the
do-not-merge/hold
frobware
force-pushed
the
OCPBUGS-43745-idle-close-on-response
branch
from
a7dea46 to
991d367
Compare
|
/testwith openshift/cluster-ingress-operator/release-4.18/e2e-aws-operator openshift/router#639 |
|
@frobware, |
|
/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639 |
frobware
changed the title
frobware
force-pushed
the
OCPBUGS-43745-idle-close-on-response
branch
from
991d367 to
052f6b6
Compare
frobware
force-pushed
the
OCPBUGS-43745-idle-close-on-response
branch
from
052f6b6 to
0aa6244
Compare
|
/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639 |
frobware
force-pushed
the
OCPBUGS-43745-idle-close-on-response
branch
from
0aa6244 to
1072f8f
Compare
openshift-merge-robot
added
the
needs-rebase
frobware
force-pushed
the
OCPBUGS-43745-idle-close-on-response
branch
2 times, most recently
from
f89fbb2 to
9707f72
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639 |
frobware
force-pushed
the
OCPBUGS-43745-idle-close-on-response
branch
from
9707f72 to
77673b3
Compare
|
/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639 |
frobware
force-pushed
the
OCPBUGS-43745-idle-close-on-response
branch
from
77673b3 to
3029807
Compare
|
/assign |
|
openshift/router#639 has merged. /test all |
|
The new e2e test /hold |
openshift-ci
bot
added
the
do-not-merge/hold
alebedev87
reviewed
Jan 6, 2025
test/e2e/idle_connection_test.go
Outdated
Comment on lines
393
to
486
| description: "Switch to web-service-1 and fetch response", | ||
| action: func(httpClient *http.Client) (string, error) { | ||
| if err := idleConnectionSwitchRouteService(t, routeName, ic.Name, webService1); err != nil { | ||
| return "", err | ||
| } | ||
| return idleConnectionFetchResponse(httpClient, elbHostname, routeHost) | ||
| }, | ||
| expectedResponse: func(policy operatorv1.IngressControllerConnectionTerminationPolicy) string { | ||
| return webService1 | ||
| }, |
There was a problem hiding this comment.
I'm not sure I understand this test case.
- Whichever policy we start from the route is created with webService1 so switching to webService1 doesn't change anything.
- If we started from
Immediatepolicy (first policy) and then switched toDeferred(second policy) we should have webService2 in the config (from the first policy test case) so the expected response should be webService2.
There was a problem hiding this comment.
I consider it a pre-condition. We need to assert that the first response is to web-service-1 for either Immediate or Deferred. That establishes our open connection.
There was a problem hiding this comment.
We need to start from a known point when we cycle from intermediate to deferred. Or vice-versa when we back port to older releases. It helps reset the test.
frobware
force-pushed
the
OCPBUGS-43745-idle-close-on-response
branch
from
e0d930d to
1019db3
Compare
|
verify test failing due to recent rebase. |
Successful test with packet captureFailed test with packet captureCapturing these results for now, as the test fails infrequently for me, though GCP seems to flake more often than AWS. Using a single instance of |
frobware
force-pushed
the
OCPBUGS-43745-idle-close-on-response
branch
3 times, most recently
from
c8b9671 to
b5c7522
Compare
|
/test e2e-gcp-operator |
|
/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639 |
alebedev87
reviewed
Jan 9, 2025
Enhanced response handlers (`/` and `/healthz`) to include pod-specific headers (`x-pod-name` and `x-pod-namespace`). Introduced new environment variables to control HTTP and HTTPS listeners: - `HTTP2_TEST_SERVER_ENABLE_HTTP_LISTENER`: Enables/disables the HTTP listener. - `HTTP2_TEST_SERVER_ENABLE_HTTPS_LISTENER`: Enables/disables the HTTPS listener. Improved error handling to log and terminate if no listeners are enabled, providing flexibility in determining which listeners to activate.
Pickup openshift/api#2102 % git show 27316471eb72fe8fcf0d44fb5a0602f698f253dc commit 27316471eb72fe8fcf0d44fb5a0602f698f253dc Merge: de9de05a8 b7417509c Author: openshift-merge-bot[bot] <148852131+openshift-merge-bot[bot]@users.noreply.github.com> Date: Wed Dec 18 10:31:50 2024 +0000 Merge pull request #2102 from frobware/OCPBUGS-43745-idle-close-on-response OCPBUGS-43745: Add IdleCloseOnResponse field to IngressControllerSpec Vendoring steps: $ go mod edit -replace github.com/openshift/api=github.com/openshift/api@27316471eb72fe8fcf0d44fb5a0602f698f253dc $ go mod tidy $ go mod vendor $ make update
frobware
force-pushed
the
OCPBUGS-43745-idle-close-on-response
branch
from
b5c7522 to
1d8ae99
Compare
|
/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639 |
Introduce logic in desiredRouterDeployment to set the environment variable `ROUTER_IDLE_CLOSE_ON_RESPONSE` when the `IdleConnectionTerminationPolicy` field in the IngressController spec is set to `Deferred`. This change enables configuring HAProxy with the `idle-close-on-response` option for better control over idle connection termination behaviour.
frobware
force-pushed
the
OCPBUGS-43745-idle-close-on-response
branch
from
1d8ae99 to
f61bdaf
Compare
|
/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#639 |
|
/test e2e-aws-operator |
|
/test hypershift-e2e-aks |
This was referenced Jan 10, 2025
|
|
|
Re: e2e-aws-operator. Last failure was: |
|
/test e2e-aws-operator |
|
|
|
@frobware: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce logic in desiredRouterDeployment to set the environmentvariable
ROUTER_IDLE_CLOSE_ON_RESPONSEwhen theIdleConnectionTerminationPolicyfield in the IngressController spec is set toDeferred. This change enables configuring HAProxy with theidle-close-on-responseoption for better control over idle connection termination behaviour.Requires: